Skip to content

ruby 3.4.9#2035

Merged
dczulada merged 3 commits intomasterfrom
ruby_3_4_9
Apr 15, 2026
Merged

ruby 3.4.9#2035
dczulada merged 3 commits intomasterfrom
ruby_3_4_9

Conversation

@dczulada
Copy link
Copy Markdown
Contributor

@dczulada dczulada commented Apr 8, 2026

Pull requests into Cypress require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@dczulada dczulada marked this pull request as ready for review April 8, 2026 19:38
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.01%. Comparing base (5f31e0f) to head (42e57b3).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2035      +/-   ##
==========================================
+ Coverage   95.96%   96.01%   +0.04%     
==========================================
  Files         158      158              
  Lines        7169     7170       +1     
==========================================
+ Hits         6880     6884       +4     
+ Misses        289      286       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elsaperelli elsaperelli self-requested a review April 14, 2026 13:50
@elsaperelli elsaperelli self-assigned this Apr 14, 2026
elsaperelli
elsaperelli approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! I was able to install easily with rbenv and looks like bundle update, bundle install and starting it up all work.

My only suggestion is- do we need to update the Ruby version in the Dockerfile?

@dczulada dczulada merged commit 89b4fd3 into master Apr 15, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elsaperelli elsaperelli elsaperelli approved these changes

Assignees

@elsaperelli elsaperelli

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dczulada @elsaperelli